[webkit-reviews] review granted: [Bug 67174] Unzip initialization lists and constructors in JSCell hierarchy (4/7) : [Attachment 105882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 08:36:56 PDT 2011

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67174: Unzip initialization lists and constructors in JSCell hierarchy

Attachment 105882: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105882&action=review

> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:82
> +void JSCallbackObject<Parent>::finishCreation(JSGlobalData& globalData)
> +{
> +    UNUSED_PARAM(globalData);

Why not just leave the parameter name out instead? That’s the best way to mark
an argument as unused in C++ functions.

> Source/JavaScriptCore/runtime/DateInstance.cpp:46
> +    finishCreation(exec->globalData(), jsNumber(timeClip(time)));

I would think we’d want the jsNumber function call inside the finishCreation

More information about the webkit-reviews mailing list