[webkit-reviews] review granted: [Bug 67174] Unzip initialization lists and constructors in JSCell hierarchy (4/7) : [Attachment 105882] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67174: Unzip initialization lists and constructors in JSCell hierarchy
(4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Attachment 105882: Patch
https://bugs.webkit.org/attachment.cgi?id=105882&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105882&action=review


> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:82
> +void JSCallbackObject<Parent>::finishCreation(JSGlobalData& globalData)
> +{
> +    UNUSED_PARAM(globalData);

Why not just leave the parameter name out instead? That’s the best way to mark
an argument as unused in C++ functions.

> Source/JavaScriptCore/runtime/DateInstance.cpp:46
> +    finishCreation(exec->globalData(), jsNumber(timeClip(time)));

I would think we’d want the jsNumber function call inside the finishCreation
function.