[webkit-reviews] review requested: [Bug 66198] [CSSRegions] Regions should not slice line box rendering : [Attachment 105950] Patch V3

[bugzilla-daemon at webkit.org]

Chiculita Alexandru <achicu at adobe.com> has asked  for review:
Bug 66198: [CSSRegions] Regions should not slice line box rendering
https://bugs.webkit.org/show_bug.cgi?id=66198

Attachment 105950: Patch V3
https://bugs.webkit.org/attachment.cgi?id=105950&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Reverted the unsplittable floats check from the previous patch. There's an
issue that needs more code change and I would like to split that into a
different patch. The issue is reproduced when there are two left floats and the
one on the right has bigger height. If the float on the right is not small
enough to fit in the current region, it will be moved to the following one, but
it will not be realigned to the left margin. I think this one can be reproduced
with columns and break-inside: avoid.

Also blocks with region-break-inside: avoid should just find the first region
to fit their needs. Currently, only the following region is checked. Will fix
that in a different patch.