[webkit-reviews] review denied: [Bug 70379] Canvas filling paths or rects need to be invalidate larger rects for some compositing modes. : [Attachment 113124] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Ben Wells
<benwells at chromium.org>'s request for review:
Bug 70379: Canvas filling paths or rects need to be invalidate larger rects for
some compositing modes.
https://bugs.webkit.org/show_bug.cgi?id=70379

Attachment 113124: Patch
https://bugs.webkit.org/attachment.cgi?id=113124&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113124&action=review


Need tests

> Source/WebCore/ChangeLog:8
> +	   No new tests.

the way we normally test invalidation rects like this is via repaint tests -
paint once, then do a draw, then paint again and see if the repainted area is
correct. we probably already have some for canvas draws already.