[webkit-reviews] review granted: [Bug 71229] V8MessageEvent::dataAccessorGetter does not return a reference to its caller : [Attachment 113122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 31 19:31:39 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dave Michael
<dmichael at chromium.org>'s request for review:
Bug 71229: V8MessageEvent::dataAccessorGetter does not return a reference to
its caller
https://bugs.webkit.org/show_bug.cgi?id=71229

Attachment 113122: Patch
https://bugs.webkit.org/attachment.cgi?id=113122&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113122&action=review


> Source/WebCore/ChangeLog:8
> +	   V8MessageEvent::dataAccessorGetter does not return a reference to
its caller
> +	   https://bugs.webkit.org/show_bug.cgi?id=71229
> +
> +	   Reviewed by Adam Barth.
> +
> +	   Test: fast/events/dispatch-message-string-data.html

Generally we prefer more of an explanation of why you're making this change. 
Often this duplicates information in the bug comments, but helps folks who
stumble upon this commit later.


More information about the webkit-reviews mailing list