[webkit-reviews] review granted: [Bug 71229] V8MessageEvent::dataAccessorGetter does not return a reference to its caller : [Attachment 113085] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dave Michael
<dmichael at chromium.org>'s request for review:
Bug 71229: V8MessageEvent::dataAccessorGetter does not return a reference to
its caller
https://bugs.webkit.org/show_bug.cgi?id=71229

Attachment 113085: Patch
https://bugs.webkit.org/attachment.cgi?id=113085&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113085&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This line will prevent the patch from being landed.  You have a test now, so
referencing it is probably the thing to do.

> LayoutTests/fast/events/dispatch-message-string-data.html:6
> +<script>

I would have expected a call to layoutTestController.dumpAsText() and
layoutTestController.waitUntilDone(), etc.  These are usually guarded by
checking if (window.layoutTestController) .  Maybe there here and I don't see
them?