[webkit-reviews] review denied: [Bug 68617] When page scaling is in use position:fixed has incorrect results : [Attachment 113102] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 68617: When page scaling is in use position:fixed has incorrect results
https://bugs.webkit.org/show_bug.cgi?id=68617

Attachment 113102: Patch
https://bugs.webkit.org/attachment.cgi?id=113102&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113102&action=review


> Source/WebCore/page/FrameView.cpp:1431
> +void FrameView::setLayoutFixedElementsRelativeToFrame(bool
layoutFixedElementsRelativeToFrame)

This still doesn't read well. It should be
setFixedElementsLaidOutRelativeToFrame (or ..Positioned...).

Or you could put a "should" in front.

> Source/WebCore/rendering/RenderBox.cpp:2335
> +    if (style() && style()->position() == FixedPosition && frame &&
frameView && frameView->layoutFixedElementsRelativeToFrame())
> +	   return (view()->isHorizontalWritingMode() ?
frameView->visibleWidth() : frameView->visibleHeight()) /
frame->frameScaleFactor();

You can't just look for position:fixed here, because transforms act as fixed
position containers. See discussion in bug 69796.