[webkit-reviews] review denied: [Bug 70765] Default <select multiple> expands up to 10 items instead of showing 4 : [Attachment 113026] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 70765: Default <select multiple> expands up to 10 items instead of showing
4
https://bugs.webkit.org/show_bug.cgi?id=70765

Attachment 113026: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=113026&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113026&action=review


> Source/WebCore/rendering/RenderListBox.cpp:217
> +	   return max(defaultSize, specifiedSize);

This change is incorrect. The default size and the minimum are not the same
thing. We have a minimum of 4 because of the minimum size that is big enough so
a scrollbar works. Platforms that do scrolling with different scrollbar designs
might even want a different minimum. This is not the same number as the 4 in
the HTML standard.

> Source/WebCore/rendering/RenderListBox.cpp:218
> +    return min(defaultSize, numItems());

This is not what the specification says. It says that the size should be 4 even
if there is only 1 item. And the old code did that. You are removing that old
minimum size of 4 here.