[webkit-reviews] review denied: [Bug 71249] Switch RenderObject to layout abstraction : [Attachment 113097] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 71249: Switch RenderObject to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71249

Attachment 113097: Patch
https://bugs.webkit.org/attachment.cgi?id=113097&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113097&action=review


> Source/WebCore/rendering/RenderObject.cpp:794
> +    int width = roundf((side == BSTop || side == BSBottom ? y2 - y1 : x2 -
x1));

The round function specifically takes a “float” so is not appropriate to round
a LayoutUnit to an int. If LayoutUnit was a double or int it would be quite
inefficient!

> Source/WebCore/rendering/RenderObject.h:1052
> -inline int adjustForAbsoluteZoom(int value, RenderObject* renderer)
> +inline float adjustForAbsoluteZoom(int value, RenderObject* renderer)

I think this change should be landed separately with its own review and
rationale.