[webkit-reviews] review granted: [Bug 20795] text/plain form encoding ignored and incorrectly specified in request header : [Attachment 112740] updated_patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 20795: text/plain form encoding ignored and incorrectly specified in
request header
https://bugs.webkit.org/show_bug.cgi?id=20795

Attachment 112740: updated_patch
https://bugs.webkit.org/attachment.cgi?id=112740&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112740&action=review


> Source/WebCore/platform/network/FormData.h:145
> +    static EncodingType parseEncodingType(const String& type)
> +    {
> +	   if (equalIgnoringCase(type, "text/plain"))
> +	       return TextPlain;
> +	   if (equalIgnoringCase(type, "multipart/form-data"))
> +	       return MultipartFormData;
> +	   return FormURLEncoded;
> +    }

Seems a little ugly to include this entire function body here in the class
definition.