[webkit-reviews] review denied: [Bug 71237] BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects : [Attachment 113087] Make our PortFactory mocking slightly more explicit

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 71237: BaselineOptimizer tests should use mocks instead of real
Executive/FileSystem objects
https://bugs.webkit.org/show_bug.cgi?id=71237

Attachment 113087: Make our PortFactory mocking slightly more explicit
https://bugs.webkit.org/attachment.cgi?id=113087&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113087&action=review


> Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:41
> +	   host.port_factory = PortFactory(host)  # We want a real PortFactory,
but it should use mocks.

Okay, I'm lost again. Why does the host have a port_factory? That seems like a
layering inversion.