[webkit-reviews] review granted: [Bug 70991] window.onerror doesn't work with inline (attribute) scripts : [Attachment 113021] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 70991: window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991

Attachment 113021: Patch
https://bugs.webkit.org/attachment.cgi?id=113021&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113021&action=review


r=me

> Source/WebCore/bindings/js/JSLazyEventListener.cpp:102
> +	   reportCurrentException(exec);
>	   exec->clearException();

It seems like WebCore wants an idiom where any script execution checks for and
reports an exception. Long-term, it would be nice to abstract this into a
common helper function / object, instead of duplicating it at each call site.