[webkit-reviews] review granted: [Bug 71202] DFG OSR exits should add to value profiles : [Attachment 113023] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 71202: DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202

Attachment 113023: the patch
https://bugs.webkit.org/attachment.cgi?id=113023&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113023&action=review


> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:642
> -    speculationCheck(m_jit.branchTest32(MacroAssembler::Zero, scratchReg));
> +    speculationCheck(JSValueRegs(), NoNode,
m_jit.branchTest32(MacroAssembler::Zero, scratchReg));

Might be nice to be able to record that we're seeing ropes here -- if we are
there's no point in planting an inline character access as we currently do