[webkit-reviews] review denied: [Bug 70181] Web Inspector: unindent edited text by pressing Shift + Tab : [Attachment 112862] First try

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Nikita Vasilyev
<me at elv1s.ru>'s request for review:
Bug 70181: Web Inspector: unindent edited text by pressing Shift + Tab
https://bugs.webkit.org/show_bug.cgi?id=70181

Attachment 112862: First try
https://bugs.webkit.org/attachment.cgi?id=112862&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112862&action=review


> Source/WebCore/inspector/front-end/TextViewer.js:1062
> +	       range.startColumn -=
WebInspector.settings.textEditorIndent.get().length;

This can go negative, no?

> Source/WebCore/inspector/front-end/TextViewer.js:1063
> +	       var newRange = this._setText(range, "");

Unindent should only be available for indented line.