[webkit-reviews] review denied: [Bug 70936] Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management : [Attachment 112860] [PATCH] Suggested solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 31 02:07:48 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 70936: Web Inspector: [refactoring] TextPrompt: ensure encapsulation,
extract history management
https://bugs.webkit.org/show_bug.cgi?id=70936

Attachment 112860: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=112860&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112860&action=review


> Source/WebCore/inspector/front-end/TextPrompt.js:185
> +    _onKeyDown: function(event)

rename to onKeyDown and allow overriding for complex cases.

> Source/WebCore/inspector/front-end/TextPrompt.js:525
> +    this.commitOnTabWithSuggestion = false;

Could you please implement it using setCommitOn... on the
TextPromptWithHistory?

> Source/WebCore/inspector/front-end/TextPrompt.js:531
> +    this.coalesceHistoryDups = true;

nit: Dupes?


More information about the webkit-reviews mailing list