[webkit-reviews] review granted: [Bug 71205] [Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed : [Attachment 113015] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 30 23:33:24 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 71205: [Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way
more often than needed
https://bugs.webkit.org/show_bug.cgi?id=71205
Attachment 113015: Patch
https://bugs.webkit.org/attachment.cgi?id=113015&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113015&action=review
> Source/WebKit/chromium/ChangeLog:9
> + calling get() on these pointer types. This patch cleans up most
(all?)
Nit: one space after period.
> Source/WebKit/chromium/src/WebViewImpl.cpp:2180
> + HTMLInputElement* inputElem =
static_cast<HTMLInputElement*>(focusedNode.get());
Can we call Node::toInputElement here?
More information about the webkit-reviews
mailing list