[webkit-reviews] review requested: [Bug 71202] DFG OSR exits should add to value profiles : [Attachment 113012] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 30 22:02:30 PDT 2011
Filip Pizlo <fpizlo at apple.com> has asked for review:
Bug 71202: DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202
Attachment 113012: the patch
https://bugs.webkit.org/attachment.cgi?id=113012&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This is still a work in progress, but it's doing nice things for performance.
Benchmark report for SunSpider, V8, and Kraken.
VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc
"OSRExitProfile" at /Volumes/Data/pizlo/OpenSource/WebKitBuild/Release/jsc
Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark.
Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used
the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times
with 95% confidence intervals in
milliseconds.
TipOfTree
OSRExitProfile
SunSpider:
3d-cube 7.4476+-0.2451 ?
7.4765+-0.3462 ?
3d-morph 7.5905+-0.1488 ?
7.7374+-0.1980 ? might be 1.0194x slower
3d-raytrace 7.6253+-0.1928
7.5224+-0.1804 might be 1.0137x faster
access-binary-trees 1.6272+-0.0670 ?
1.6485+-0.0665 ? might be 1.0131x slower
access-fannkuch 6.6357+-0.1318
6.5111+-0.1041 might be 1.0191x faster
access-nbody 3.7730+-0.0934 ?
3.8759+-0.0823 ? might be 1.0273x slower
access-nsieve 2.7499+-0.1359
2.6392+-0.0771 might be 1.0420x faster
bitops-3bit-bits-in-byte 1.2663+-0.0178 ?
1.3191+-0.0398 ? might be 1.0417x slower
bitops-bits-in-byte 2.4506+-0.1165
2.4098+-0.0593 might be 1.0169x faster
bitops-bitwise-and 3.3116+-0.0798 ?
3.4150+-0.1532 ? might be 1.0312x slower
bitops-nsieve-bits 5.4553+-0.1166 ?
5.5435+-0.1914 ? might be 1.0162x slower
controlflow-recursive 2.1771+-0.0652
2.1228+-0.0364 might be 1.0256x faster
crypto-aes 7.4525+-0.2351 ?
7.4617+-0.2610 ?
crypto-md5 2.8494+-0.1006
2.7413+-0.0958 might be 1.0394x faster
crypto-sha1 2.4779+-0.0862
2.4676+-0.0633
date-format-tofte 10.4422+-0.3701
10.2439+-0.2959 might be 1.0194x faster
date-format-xparb 8.9904+-0.2293 ?
9.5272+-0.3653 ? might be 1.0597x slower
math-cordic 6.5545+-0.1336 ?
6.6676+-0.1387 ? might be 1.0172x slower
math-partial-sums 7.3791+-0.1189 ?
7.5362+-0.1761 ? might be 1.0213x slower
math-spectral-norm 2.5897+-0.0553 ?
2.6413+-0.0944 ? might be 1.0199x slower
regexp-dna 11.7961+-0.3366
11.6946+-0.2568
string-base64 4.2983+-0.1578
4.2516+-0.0844 might be 1.0110x faster
string-fasta 6.3607+-0.1389 ?
6.3615+-0.1704 ?
string-tagcloud 11.8896+-0.3017 ?
12.1887+-0.5354 ? might be 1.0252x slower
string-unpack-code 20.9870+-0.5481 ?
21.0838+-0.5925 ?
string-validate-input 5.5790+-0.3440
5.3810+-0.2450 might be 1.0368x faster
<arithmetic> * 6.2214+-0.0307 ?
6.2488+-0.0329 ?
<geometric> 5.0128+-0.0298 ?
5.0252+-0.0299 ?
<harmonic> 3.9985+-0.0460 ?
4.0096+-0.0352 ?
TipOfTree
OSRExitProfile
V8:
crypto 73.2589+-0.4478 ?
74.0815+-0.5231 ? might be 1.0112x slower
deltablue 167.0489+-1.6830
166.7101+-2.2811
earley-boyer 90.8381+-0.6412 ?
91.8894+-1.2159 ? might be 1.0116x slower
raytrace 63.6327+-0.7158 ^
62.3539+-0.4908 ^ definitely 1.0205x faster
regexp 105.8577+-0.6788 ?
106.2984+-1.1406 ?
richards 124.2458+-0.8623 ?
125.4560+-0.5646 ?
splay 92.4507+-0.8355 ?
93.2114+-0.5934 ?
<arithmetic> 102.4761+-0.3628 ?
102.8572+-0.3517 ?
<geometric> * 97.8644+-0.3566 ?
98.1744+-0.2179 ?
<harmonic> 93.7314+-0.3717 ?
93.9123+-0.1826 ?
TipOfTree
OSRExitProfile
Kraken:
ai-astar 498.1019+-3.5555
497.8109+-4.3642
audio-beat-detection 192.9884+-2.0270
192.5105+-1.6015
audio-dft 267.9992+-3.7820
264.1323+-2.5511 might be 1.0146x faster
audio-fft 125.1567+-1.0422
124.3891+-1.0387
audio-oscillator 252.5195+-1.7051
250.8467+-1.2936
imaging-darkroom 405.0860+-3.5058 ^
301.0530+-4.2403 ^ definitely 1.3456x faster
imaging-desaturate 225.8273+-1.8701
225.7868+-0.7781
imaging-gaussian-blur 557.1729+-2.5246
553.0562+-2.2644
json-parse-financial 58.0259+-0.4031
57.7457+-0.3248
json-stringify-tinderbox 68.2285+-0.3516 ?
68.4495+-0.3577 ?
stanford-crypto-aes 133.0071+-1.8636 ^
96.5019+-0.2555 ^ definitely 1.3783x faster
stanford-crypto-ccm 100.1896+-0.6561 ?
100.4740+-1.8711 ?
stanford-crypto-pbkdf2 195.5539+-4.3864
194.4378+-2.4384
stanford-crypto-sha256-iterative 70.6284+-0.4679 !
80.3949+-0.5279 ! definitely 1.1383x slower
<arithmetic> * 225.0347+-0.8813 ^
214.8278+-0.7069 ^ definitely 1.0475x faster
<geometric> 177.2422+-0.6686 ^
170.6528+-0.3701 ^ definitely 1.0386x faster
<harmonic> 139.6617+-0.4457 ^
136.6990+-0.2430 ^ definitely 1.0217x faster
TipOfTree
OSRExitProfile
All benchmarks:
<arithmetic> 85.7356+-0.3072 ^
82.7672+-0.2422 ^ definitely 1.0359x faster
<geometric> 22.5702+-0.0881 ^
22.3579+-0.0672 ^ definitely 1.0095x faster
<harmonic> 7.0387+-0.0789 ?
7.0555+-0.0602 ?
TipOfTree
OSRExitProfile
Geomean of preferred means:
<scaled-result> 51.5526+-0.1653 ^
50.8890+-0.1053 ^ definitely 1.0130x faster
More information about the webkit-reviews
mailing list