[webkit-reviews] review granted: [Bug 71034] Remove need for virtual JSObject::unwrappedObject : [Attachment 113000] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 71034: Remove need for virtual JSObject::unwrappedObject
https://bugs.webkit.org/show_bug.cgi?id=71034

Attachment 113000: Patch
https://bugs.webkit.org/attachment.cgi?id=113000&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113000&action=review


r=me

> Source/JavaScriptCore/runtime/JSGlobalThis.h:51
> +    JSObject* unwrappedObject();

Please make this return JSGlobalObject*, since it's not the case that we're
capable of wrapping any kind of JSObject.

> Source/JavaScriptCore/runtime/JSGlobalThis.h:68
> +    WriteBarrier<JSGlobalObject> m_globalVariables;

Please change this name to match its accessor ("unwrappedObject()").