[webkit-reviews] review granted: [Bug 71191] The DFG inliner should not flush the callee : [Attachment 112997] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 71191: The DFG inliner should not flush the callee
https://bugs.webkit.org/show_bug.cgi?id=71191

Attachment 112997: the patch
https://bugs.webkit.org/attachment.cgi?id=112997&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112997&action=review


It would be nice is we could elide the argument flushing when we can prove no
OSRs will happen

> Source/JavaScriptCore/bytecode/CodeOrigin.h:81
>      unsigned stackOffset;
> -    unsigned calleeVR;
> +    WriteBarrier<JSFunction> callee;
>      CodeOrigin caller;

can we move stackOffset down the struct? changing from an unsigned to a pointer
should increase alignment requirements so i think this ends up increasing the
struct size by 12 bytes rather than 4