[webkit-reviews] review granted: [Bug 71052] [GTK] Visited links of a page group should be removed when clearing back/forward list : [Attachment 112907] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 29 12:53:50 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 71052: [GTK] Visited links of a page group should be removed when clearing
back/forward list
https://bugs.webkit.org/show_bug.cgi?id=71052

Attachment 112907: Updated patch
https://bugs.webkit.org/attachment.cgi?id=112907&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112907&action=review


Looks good to me, but let's wait to land this until Alex can take can answer my
question about WebKit2.

> Source/WebKit/gtk/webkit/webkitwebbackforwardlist.cpp:451
> + * Also removed is the list of visited links, removing stylization of such
elements in page.

Nit on the English:

This method also clears the list of visited links which means that all links
appear unvisited.


More information about the webkit-reviews mailing list