[webkit-reviews] review granted: [Bug 71148] Use after free in TextTrack::~TextTrack : [Attachment 112962] addressing Darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 28 23:37:02 PDT 2011


Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 71148: Use after free in TextTrack::~TextTrack
https://bugs.webkit.org/show_bug.cgi?id=71148

Attachment 112962: addressing Darin's comments
https://bugs.webkit.org/attachment.cgi?id=112962&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112962&action=review


r+, but please add the test results before committing.

> LayoutTests/ChangeLog:9
> +	   * media/track/track-text-track-destructor-crash.html: Added.
> +

Looks like you forgot to add the expected results.


More information about the webkit-reviews mailing list