[webkit-reviews] review granted: [Bug 71134] De-virtualize JSObject::defineGetter : [Attachment 112902] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 71134: De-virtualize JSObject::defineGetter
https://bugs.webkit.org/show_bug.cgi?id=71134

Attachment 112902: Patch
https://bugs.webkit.org/attachment.cgi?id=112902&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112902&action=review


> Source/WebKit/qt/Api/qwebframe.cpp:517
> -    window->defineGetter(exec,
propertyName.get()->identifier(&exec->globalData()), ::toJS(function),
> +    window->methodTable()->defineGetter(window, exec,
propertyName.get()->identifier(&exec->globalData()), ::toJS(function),
>			    JSC::ReadOnly | JSC::DontEnum | JSC::DontDelete);

Not to everyone on the project: Here is an example of why we don’t line up
subsequent lines of multiline statements.