[webkit-reviews] review requested: [Bug 60120] editing/execCommand/append-node-under-document.html is flaky on chromium debug bots : [Attachment 112886] fix attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 28 14:03:46 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 60120: editing/execCommand/append-node-under-document.html is flaky on
chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=60120

Attachment 112886: fix attempt
https://bugs.webkit.org/attachment.cgi?id=112886&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #7)
> (From update of attachment 112886 [details])
> I would like to see an explanation of how this is timing dependent. If it
always failed on all platforms, I would be OK with this change. But being flaky
and on one platform implies a bug to me.

It was timing out on all debug builds, which seems to indicate that there's
some race condition in loader, etc... But that's out of scope for this bug. I'd
much rather have this test coverage by speculatively fix the test than having
PASS FAIL expectation in test_expectations.txt because that's going to shadow
any real failures we might have in the future.


More information about the webkit-reviews mailing list