[webkit-reviews] review denied: [Bug 71052] [GTK] Visited links of a page group should be removed when clearing back/forward list : [Attachment 112898] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 71052: [GTK] Visited links of a page group should be removed when clearing
back/forward list
https://bugs.webkit.org/show_bug.cgi?id=71052

Attachment 112898: Patch
https://bugs.webkit.org/attachment.cgi?id=112898&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112898&action=review


Awesome! I have a couple comments below:

> Source/WebKit/gtk/webkit/webkitwebbackforwardlist.cpp:463
> +    if (!backForwardList)
> +	   return;
> +
> +    WebCore::Page* page = backForwardList->page();
> +    if (page && page->groupPtr())

I think it's okay to do this here since other ports do it, but we should update
the documentation to state that when a list is cleared it also clears the list
of visisted links.

> LayoutTests/platform/gtk/fast/block/margin-collapse/010-expected.txt:31
> -	   RenderInline {A} at (0,0) size 49x19 [color=#551A8B]
> +	   RenderInline {A} at (0,0) size 49x19 [color=#0000EE]
>	     RenderText {#text} at (259,0) size 49x19

Can you also run these tests in WebKit2? I'm surprised that they weren't
failing before there.