[webkit-reviews] review granted: [Bug 68149] CSS 2.1 failure: dynamic-top-change-001 to 004 fail : [Attachment 112882] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 68149: CSS 2.1 failure: dynamic-top-change-001 to 004 fail
https://bugs.webkit.org/show_bug.cgi?id=68149

Attachment 112882: Patch
https://bugs.webkit.org/attachment.cgi?id=112882&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112882&action=review


r=me. One minor fix I'd like you to make though.

> Source/WebCore/css/CSSStyleSelector.cpp:2488
> +    if (isInherit && m_parentStyle &&
!CSSProperty::isInheritedProperty(property)) 
> +	   m_parentStyle->setHasExplicitlyInheritedProperties();

Minor optimization you could make here is to add
!m_parentStyle->hasExplicitlyInheritedProperties() to the if. That way once the
parent style is tainted by one child, you don't waste time checking other
children.

I'm thinking of the case where you have a parent with a bunch of kids that all
inherit. The first kid taints you. No need to keep checking properties when you
look at the other kids.