[webkit-reviews] review granted: [Bug 70968] De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject : [Attachment 112732] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 70968: De-virtualize isGlobalObject, isVariableObject, isActivationObject,
and isErrorInstance in JSObject
https://bugs.webkit.org/show_bug.cgi?id=70968

Attachment 112732: Patch
https://bugs.webkit.org/attachment.cgi?id=112732&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112732&action=review


Seems like TypeInfo should eventually move to being specified in ClassInfo,
even if a copy is cached in Structure. More elegant to specify TypeInfo
declaratively, instead of through a bunch of function call arguments.

> Source/JavaScriptCore/runtime/JSType.h:47
> +    // VariableObjectType must be greater than all of the types of its
subclasses.

Less than!