[webkit-reviews] review denied: [Bug 71089] Web Inspector: Support using a different front-end in WebKit2 : [Attachment 112810] Proposed Change

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 71089: Web Inspector: Support using a different front-end in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=71089

Attachment 112810: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=112810&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112810&action=review


The patch looks ok, but we have been trying to avoid global state, so I think
it would be better for these settings to go on the WKContextRef.

> Source/WebKit2/UIProcess/API/C/mac/WKInspectorMac.h:39
> +WK_EXPORT void WKInspectorSetCustomBasePath(WKStringRef);
> +WK_EXPORT void WKInspectorSetCustomPagePath(WKStringRef);
> +WK_EXPORT void WKInspectorSetCustomLocalizedStringsPath(WKStringRef);

We usually add parameter names in API headers.	These should probably also be
per-WKContextRef, not global as they currently are.