[webkit-reviews] review denied: [Bug 70898] Range sliders and spin buttons don't work with multi-columns : [Attachment 112842] Patch 3

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied yosin at chromium.org's request for review:
Bug 70898: Range sliders and spin buttons don't work with multi-columns
https://bugs.webkit.org/show_bug.cgi?id=70898

Attachment 112842: Patch 3
https://bugs.webkit.org/attachment.cgi?id=112842&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=112842&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:2596
> +    LayoutSize containerOffset = offsetFromContainer(o, LayoutPoint());

offsetFromContainer() already calls adjustForColumns(). You should just pass
the actual point instead of the zero point so that it does the right thing,
instead of replicating adjustForColumns() below (your replicated code is also
missing the check for the progression axis). All you probably need to do is
move the offsetFromContainer() override from RenderBox to RenderBoxModelObject.