[webkit-reviews] review granted: [Bug 70890] ExceptionCode.cpp shouldn't need to know about every feature that throws exceptions : [Attachment 112831] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 70890: ExceptionCode.cpp shouldn't need to know about every feature that
throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=70890

Attachment 112831: Patch
https://bugs.webkit.org/attachment.cgi?id=112831&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112831&action=review


OK.  I get the sense you're setting the stage here.

> Source/WebCore/dom/ExceptionCode.cpp:37
> +    description = ExceptionCodeDescription(ec);

Seems you also want to inline this into ExceptionCode.	I assume there will be
some sort of ExceptionCodeFactory?