[webkit-reviews] review denied: [Bug 70951] IDL constants can't use [Reflect] : [Attachment 112817] changes added to JSC + new layout test

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Anna Cavender <annacc at chromium.org>'s
request for review:
Bug 70951: IDL constants can't use [Reflect]
https://bugs.webkit.org/show_bug.cgi?id=70951

Attachment 112817: changes added to JSC + new layout test
https://bugs.webkit.org/attachment.cgi?id=112817&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112817&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1116
> -	       my $getter = "js" . $interfaceName .
$codeGenerator->WK_ucfirst($constant->name);
> +	       my $reflect = $constant->extendedAttributes->{"Reflect"};
> +	       my $name = $reflect ? $reflect : $constant->name;
> +	       my $getter = "js" . $interfaceName .
$codeGenerator->WK_ucfirst($name);

Can we break this copy/paste code out into a function?

> Source/WebCore/bindings/scripts/test/TestObj.idl:193
> +	   const [Reflect=CONST_JAVASCRIPT] unsigned short CONST_IMPL = 15;

Isn't this backwards?  The attribute should have the implementation name and
the main declaration should have the API name that JavaScript sees.