[webkit-reviews] review denied: [Bug 70914] [EFL] build on macosx does not work for various small reasons : [Attachment 112651] add -DU_DISABLE_RENAME for icu

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied  review:
Bug 70914: [EFL] build on macosx does not work for various small reasons
https://bugs.webkit.org/show_bug.cgi?id=70914

Attachment 112651: add -DU_DISABLE_RENAME for icu
https://bugs.webkit.org/attachment.cgi?id=112651&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112651&action=review


You miss ChangeLog for this patch. You can make ChangeLog via
Tools/Script/prepare-ChangeLog script.

>> Source/WebCore/platform/cairo/WidgetBackingStore.h:27
>> +#include <cairo/cairo.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please run Tools/Script/check-webkit-style script before submitting this patch.


> Source/cmake/FindEFL.cmake:7
> +  eina>=1.0.99

Why do you reduce efl library version ?