[webkit-reviews] review granted: [Bug 70442] [chromium] Track when CCLayerImpl properties have changed : [Attachment 112769] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 27 15:40:22 PDT 2011
James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 70442: [chromium] Track when CCLayerImpl properties have changed
https://bugs.webkit.org/show_bug.cgi?id=70442
Attachment 112769: Patch
https://bugs.webkit.org/attachment.cgi?id=112769&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112769&action=review
> Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp:242
> + if (m_bounds != bounds) {
actually now that i look at this again we'd normally do this with early-return
to avoid the extra indentation level. nothin' but nitpicks here!
this is fine to land as-is, i think we've gone through enough iterations
More information about the webkit-reviews
mailing list