[webkit-reviews] review granted: [Bug 63970] new-run-webkit-tests doesn't understand --qt or --gtk : [Attachment 112760] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 63970: new-run-webkit-tests doesn't understand --qt or --gtk
https://bugs.webkit.org/show_bug.cgi?id=63970

Attachment 112760: Patch
https://bugs.webkit.org/attachment.cgi?id=112760&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112760&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:312
>	   optparse.make_option("--full-results-html", action="store_true",
>	       default=False,
> -	       help="Show all failures in results.html, rather than only "
> -		    "regressions"),
> +	       help="Show all failures in results.html, rather than only
regressions"),

Not related to this patch, but I *think* this is a misnomer now. I think all
this does is that it decides whether we open the results.html page in cases
where all the failures are expected (e.g. they're all listed in
test_expectations).

I guess what it should do is open the results.html page with the show expected
failures checkbox checked.