[webkit-reviews] review denied: [Bug 71023] [chromium] Paint directly to shared memory buffers : [Attachment 112730] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 71023: [chromium] Paint directly to shared memory buffers
https://bugs.webkit.org/show_bug.cgi?id=71023

Attachment 112730: Patch
https://bugs.webkit.org/attachment.cgi?id=112730&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112730&action=review


> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:156
> +void TiledLayerChromium::prepareCompositorResources(GraphicsContext3D*
context, CCTextureUpdater& updater)

This also looks mostly like a copy-paste of updateCompositorResources()

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:430
> +void CCLayerTreeHost::prepareCompositorResources(GraphicsContext3D* context,
CCTextureUpdater& updater)

I think that functions like this are not going to be maintainable. This is
almost entirely a copy-paste of updateCompositorResources() - it seems like
what you need is an iterator pattern so we can keep the logic of 'how do we go
through the layer list' in one place and the and potentially do different
things at each layer.