[webkit-reviews] review denied: [Bug 71042] Don't use GOwnPtr for ref-counted objects : [Attachment 112723] [GStreamer] Don't use GOwnPtr for ref-counted objects https://bugs.webkit.org/show_bug.cgi?id=71042

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Jonathon Jongsma (jonner)
<jonathon at quotidian.org>'s request for review:
Bug 71042: Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042

Attachment 112723: [GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042
https://bugs.webkit.org/attachment.cgi?id=112723&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112723&action=review


Thanks for the cleanup. Just a nit below.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:91
> +    GstElement* p = 0;

We typically use full words for variable names in WebKit. If you want you call
this videoSinkPtr or maybe we can consider adding a adoptOutPtr method to
GRefPtr.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:163
> +    GstElement* p = 0;

Ditto.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1013

> +    GstElement* p = 0;

Ditto.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1026

> +    GstElement* p = 0;

Ditto.