[webkit-reviews] review granted: [Bug 70814] [GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API : [Attachment 112326] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 27 12:13:02 PDT 2011


Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 70814: [GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=70814

Attachment 112326: Patch
https://bugs.webkit.org/attachment.cgi?id=112326&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112326&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:307
>      WKPageLoadURL(toAPI(page), url.get());
> +    webkitWebViewUpdateURI(webView);

This made me a bit nervous, but notice I didn't read WKPageLoadURL's code yet.
You are sure there isn't a race here, I assume? Other than that looks great.


More information about the webkit-reviews mailing list