[webkit-reviews] review requested: [Bug 71042] Don't use GOwnPtr for ref-counted objects : [Attachment 112716] patch to use GRefPtr instead

[bugzilla-daemon at webkit.org]

Jonathon Jongsma (jonner) <jonathon at quotidian.org> has asked  for review:
Bug 71042: Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042

Attachment 112716: patch to use GRefPtr instead
https://bugs.webkit.org/attachment.cgi?id=112716&action=review

------- Additional Comments from Jonathon Jongsma (jonner)
<jonathon at quotidian.org>
In a few places in the gstreamer media player implementation, GOwnPtr is used
with ref-counted objects (GstElement, etc).  The implementation is basically
correct, but the semantics are confusing because a GOwnPtr is meant to indicate
exclusive ownership of memory, whereas ref-counted objects have shared
ownership by definition.  Changing to use GRefPtr makes things a bit more
verbose (due to not having the outPtr() method), but I think it is more correct
and less confusing.