[webkit-reviews] review denied: [Bug 71017] Web Inspector: introduce script origin and push it into the inspector. : [Attachment 112691] [Patch] Straw man with jsc bots happy.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 71017: Web Inspector: introduce script origin and push it into the
inspector.
https://bugs.webkit.org/show_bug.cgi?id=71017

Attachment 112691: [Patch] Straw man with jsc bots happy.
https://bugs.webkit.org/attachment.cgi?id=112691&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112691&action=review


This patch does not contained any tests, as far as I can tell.

> Source/WebCore/bindings/js/ScriptSourceCode.h:67
> +    ScriptOrigin origin() const { return m_origin; }

This is a really confusing name.  I would have expected this to be the security
origin of the script.