[webkit-reviews] review granted: [Bug 71028] Allow column progression to be independent of writing mode : [Attachment 112701] Enable column progression along the block axis and add a CSS property to enable it

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 71028: Allow column progression to be independent of writing mode
https://bugs.webkit.org/show_bug.cgi?id=71028

Attachment 112701: Enable column progression along the block axis and add a CSS
property to enable it
https://bugs.webkit.org/attachment.cgi?id=112701&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112701&action=review


> Source/WebCore/ChangeLog:14
> +	   Allow “columns” to be stacked along the block axis rather than
the inline axis. This can facilitate

Character set unhappiness?

> Source/WebCore/rendering/RenderBlock.cpp:2391
> +	   BoxSide boxSide = isHorizontalWritingMode() ?
> +	       style()->isLeftToRightDirection() ? BSLeft : BSRight
> +	       : style()->isLeftToRightDirection() ? BSTop : BSBottom;

I normally put the ? on the next line just over the : in a construction like
this.