[webkit-reviews] review granted: [Bug 70733] [CSSRegions]Flag regions with custom styling : [Attachment 112655] Patch 2

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 70733: [CSSRegions]Flag regions with custom styling
https://bugs.webkit.org/show_bug.cgi?id=70733

Attachment 112655: Patch 2
https://bugs.webkit.org/attachment.cgi?id=112655&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Looks good. I'm going to give this r+, but I do think there's an eventual
problem we'll need to fix.

If a region is anonymous and doesn't have an element, but is for example
created as the result of being a pseudo-element, you need to pass that
pseudo-element information through so that it can be checked.

For example, you should be able to make a display:block ::before generated
content region. That region will have no element but should be able to match a
@region div::before { } rule.