[webkit-reviews] review granted: [Bug 70986] Add ability to check for presence of static members at compile time : [Attachment 112632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 27 08:41:56 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 70986: Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986

Attachment 112632: Patch
https://bugs.webkit.org/attachment.cgi?id=112632&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112632&action=review


Two words: robot barf.

> Source/JavaScriptCore/runtime/ClassInfo.h:65
> +struct MemberCheck##foo { \

Let's use "member" instead of "foo".


More information about the webkit-reviews mailing list