[webkit-reviews] review granted: [Bug 69151] [Qt][WK2] Synchronize tiling with accelerated compositing : [Attachment 111979] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 69151: [Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Attachment 111979: Patch
https://bugs.webkit.org/attachment.cgi?id=111979&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111979&action=review


r=me, with two changes:

1) Revert the ItemHasContents piece to avoid the ASSERT
2) Fix the location of the d->paintingIsInitialized = true assignment

We plan on doing the next qt5 update tomorrow, which will require us to adapt
to source incompatible changes (QSG* -> QQuick* renaming in qtdeclarative). So
perhaps you can land this today your time? Otherwise the patch will need a
rebase :)

> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp:160
> +float computeEffectiveOpacity(const QSGItem* item)

Missing 'static' keyword :)