[webkit-reviews] review granted: [Bug 70044] SVG Filter on a group doesn't invalidate when children are moved : [Attachment 112583] patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 70044: SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044

Attachment 112583: patch
https://bugs.webkit.org/attachment.cgi?id=112583&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112583&action=review


r=me, assuming no pixel regressions. Some comments on the test:

> LayoutTests/svg/filters/invalidate-on-child-layout.svg:1
> +<svg xmlns="http://www.w3.org/2000/svg" onload="setup()">

The onload="setup()" is not really needed. You can just use setTimeout(jump, 0)
in the <script> directly.
Also I'd rename jump to executeTest.

> LayoutTests/svg/filters/invalidate-on-child-layout.svg:6
> +    layoutTestController.display();

Why is display() needed? I guess you want to test repainting, but in the
expected.png I can not see any gray overlay, which should be produced by
display(). Can it be removed?

> LayoutTests/svg/filters/invalidate-on-child-layout.svg:16
> +    a.setAttributeNS(null,"cx",100);
> +    a.setAttributeNS(null,"cy",100);

setAttribute("cx", "100") ...

> LayoutTests/svg/filters/invalidate-on-child-layout.svg:29
> +<g filter="url(#filt)">
> +    <circle id="c" r="50" cx="50" cy="50" />

Nitpick, I'd name the resources "filter" and "circle", to avoid confusion.