[webkit-reviews] review denied: [Bug 68789] Unable to embed a flash plug-in using an <embed> element with mime type "application/octet-stream" : [Attachment 111913] patch to use src extension when no plugin is available for mimetype

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has denied KishoreGanesh
<kbolisetty at innominds.com>'s request for review:
Bug 68789: Unable to embed a flash plug-in using an <embed> element with mime
type "application/octet-stream"
https://bugs.webkit.org/show_bug.cgi?id=68789

Attachment 111913: patch to use src extension when no plugin is available for
mimetype
https://bugs.webkit.org/attachment.cgi?id=111913&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111913&action=review


Not all ports go through one of the two code paths you modified. For instance,
I believe WebKit1 on the Mac will still show the missing plug-in indicator
after this patch. r- because of that. I have other comments below.

> Source/WebCore/ChangeLog:3
> +	   Bug 68789: Using src url extension when there is no plugin to handle
specified mimetype in type attribute of embed element.

I'd just use the bug title here.

> Source/WebCore/ChangeLog:11
> +	   (WebCore::PluginDatabase::findPlugin):Modifed to make use of src
extension to find matching plugin when no plugin is found for specified mime
type.

There should be a space between the colon and the word modified. You also
misspelled modified.

> Source/WebKit2/ChangeLog:3
> +	   Bug 68789: Using src url extension when there is no plugin to handle
specified mimetype in type attribute of embed element.

I'd just use the bug title here.

> LayoutTests/ChangeLog:9
> +	   *
plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html: Test
should pass if the plugin is resolved based on extension.

This test is now incorrectly named based on what we expect it to do.

> LayoutTests/ChangeLog:11
> +	   * plugins/unsupportedmime-supportedextension.html: Added.

How is this test different than the one above? They both seem to verify that a
plug-in loads, just using different TestNetscapePlugIn mechanisms.