[webkit-reviews] review denied: [Bug 70215] Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL : [Attachment 111545] Rebased patch for review

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 70215: Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70215

Attachment 111545: Rebased patch for review
https://bugs.webkit.org/attachment.cgi?id=111545&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111545&action=review


We should not be special casing an empty JSValue.  If you get one of these,
something is probably wrong.

> Source/JavaScriptCore/runtime/JSString.h:712
> +	   if (isEmpty())
> +	       return UString();

This is wrong.	The empty value JSValue should be treated like a null pointer,
and you should never call functions on it.