[webkit-reviews] review granted: [Bug 70965] [Qt][WK2] Move the setup C API callback out of QtWebPageProxy : [Attachment 112589] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 26 13:47:41 PDT 2011
Andreas Kling <kling at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 70965: [Qt][WK2] Move the setup C API callback out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=70965
Attachment 112589: Patch
https://bugs.webkit.org/attachment.cgi?id=112589&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112589&action=review
> Source/WebKit2/ChangeLog:3
> + [Qt][WK2] Move the setup C API callback out of QtWebPageProxy
Move the C API callback setup out of QtWebPageProxy
> Source/WebKit2/UIProcess/qt/ClientImpl.h:34
> #endif /* DefaultClientCallbacksQt_h */
Just noticed this name is wrong.
> Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:173
> + WebKit::QtViewInterface* viewInterface() const { return m_viewInterface;
}
Is the WebKit:: really needed here?
More information about the webkit-reviews
mailing list