[webkit-reviews] review denied: [Bug 70816] Get rid of optional parameters in the middle in IDLs. : [Attachment 112562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 26 10:57:12 PDT 2011


Adam Barth <abarth at webkit.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 70816: Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Attachment 112562: Patch
https://bugs.webkit.org/attachment.cgi?id=112562&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
We shouldn't add a custom putImageDataCallback just to throw a different
exception.  We should fix the code generators to both throw the same exception.
 (Either exception is fine, although I'd prefer the JS exception to the DOM
exception, as discussed above.)


More information about the webkit-reviews mailing list