[webkit-reviews] review granted: [Bug 70937] Increase StringImpl Flag Bits for 8 bit Strings : [Attachment 112551] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 70937: Increase StringImpl Flag Bits for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=70937

Attachment 112551: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=112551&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112551&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   Increased the number of bits used for flags in StringImpl
> +	   from 6 to 8 bits.  Updated hash methods accordingly.
> +	   Changed hash value masking from the low bits to the high
> +	   bits.

This should say why. “This frees up 2 bits that we will be using for 8-bit
string support.”