[webkit-reviews] review denied: [Bug 70869] Fix click-before-and-after-table.html for Chromium and unskip passing editing tests : [Attachment 112449] fixes the test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 26 10:04:56 PDT 2011


Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 70869: Fix click-before-and-after-table.html for Chromium and unskip
passing editing tests
https://bugs.webkit.org/show_bug.cgi?id=70869

Attachment 112449: fixes the test
https://bugs.webkit.org/attachment.cgi?id=112449&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112449&action=review


The fix for the layout test looks fine.

> LayoutTests/platform/chromium/test_expectations.txt:-471
> -WONTFIX SKIP :
platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html = FAIL
> -WONTFIX SKIP : http/tests/security/dataTransfer-set-data-file-url.html =
FAIL

Does Chromium DRT implement window.objCPlugin?

> LayoutTests/platform/chromium/test_expectations.txt:-641
> -BUGWK60089 DEBUG : editing/selection/designmode-no-caret.html = CRASH FAIL

This test still appears to be failing everywhere (but no longer crashing).  Can
you merge this with the lines above instead?


More information about the webkit-reviews mailing list