[webkit-reviews] review granted: [Bug 70867] Use enum instead of bool to represent -webkit-column-span property. : [Attachment 112443] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 26 09:52:57 PDT 2011


Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 70867: Use enum instead of bool to represent -webkit-column-span property.
https://bugs.webkit.org/show_bug.cgi?id=70867

Attachment 112443: Patch
https://bugs.webkit.org/attachment.cgi?id=112443&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112443&action=review


> Source/WebCore/rendering/style/RenderStyleConstants.h:86
> +enum ColumnSpan { ColumnSpanOne = 0, ColumnSpanAll};

Not sure I see the value in specifying "= 0" here and not specifying "= 1". I’d
leave off the "= 0" myself.


More information about the webkit-reviews mailing list