[webkit-reviews] review requested: [Bug 47156] CSS 2.1 failure: background-intrinsic-* : [Attachment 112504] Final patch - v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 26 07:33:09 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 47156: CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

Attachment 112504: Final patch - v3
https://bugs.webkit.org/attachment.cgi?id=112504&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
CSS Gradients + zooming was broken, it turns out there is no pixel test for
that, so I added one.
Made few adjustments and cleaned up the zooming related code to make it work
for generated images, cached images and cached SVG images.
SVG Images are zoomed by adjusting their page zoom factor. Cached non-SVG
images are scaled up, and generated images render at any desired size.
Previously zooming was only handled by adjusting the size of the root <svg>
renderer, but that does not work at all with relative lengths.

The new behaviors match Opera / Firefox / IE9, finally.
We're still the only one to support the CSS 2.1 background-intrinsic* tests
perfectly - checked using latest nightlies of these browsers, except IE.


More information about the webkit-reviews mailing list